Reducing the instances of bare "import armi". #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several places in the code where a bare "import armi" is done from within the armi module. Python is really good about lazily importing large swaths of code to prevent circular imports. But this sort of thing can very easily cause opaque runtime errors. There are more places in the code where "import armi" is used, but those will all require some code refactoring to provide different pathways for the desired usage. This PR only covers the simplest cases where we can just remove the bare import and replace it without a more specific one.
|
There are still 23 instances left in ARMI with bare
We are also using bare
|
youngmit
approved these changes
Jul 28, 2021
|
Love it! We should probably pull your tables out into an issue, so they don't die in here. |
Done: #349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places in the code where a bare
import armiis done from within the armi module. Python is really good about lazily importing large swaths of code to prevent circular imports. But this sort of thing can still cause opaque runtime errors.There are more places in the code where
import armiis used, but those will all require some code refactoring to provide different pathways for the desired usage. This PR only covers the simplest cases where we can just remove the bare import and replace it without a more specific one.