Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making concatLogs work with new context.LOG_DIR #370

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

john-science
Copy link
Member

The armi.runLog.concatenateLogs() function should not be aware of the context.LOG_DIR path.

While it does not hurt us currently that concatenateLogs() is not fully in compliance, we really want this change to be made.

@john-science
Copy link
Member Author

@youngmit This should have been part of PR #369 .

@youngmit youngmit merged commit 4e100dd into terrapower:master Aug 11, 2021
@john-science john-science deleted the concatLogsLogDir branch September 10, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants