Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Code Coverage and Pylinting #429

Merged
merged 10 commits into from
Oct 5, 2021
Merged

Improving Code Coverage and Pylinting #429

merged 10 commits into from
Oct 5, 2021

Conversation

john-science
Copy link
Member

Increasing code coverage for:

  • MacroXSGenerationInterface
  • latticePhysics
  • isotopicDepletionInterface
  • neutronics.crossSectionTable
  • plotting.py

Reducing pylint errors:

  • unit tests
  • fixing strange imports
  • correctly using dict.items()

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Oct 2, 2021
@john-science
Copy link
Member Author

@youngmit I had a slow morning. Here's a cleanup PR. Don't judge me.

youngmit
youngmit suggested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@youngmit youngmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but my main concern is changing the copyright notice. I'll get back to you on that.

armi/bookkeeping/historyTracker.py Show resolved Hide resolved
armi/utils/tests/test_gridGui.py Outdated Show resolved Hide resolved
@john-science john-science merged commit d1fc198 into terrapower:master Oct 5, 2021
@john-science john-science deleted the unit_tests_2 branch October 11, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngmit youngmit youngmit approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @youngmit