Applying proper Python formatting to logging docs #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a known issue with GitHub caching badges of all kinds. Adding any query garbage to the end of our badge URL will force GitHub to grab a new copy of our badge. Which means any time our code coverage changes substantially we should rev the kill_count in this URL. It appears GitHub is defeating the whole purpose of these badges, but there isn't much we can do about that for now.
ntouran
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RST was not properly rendering the Python code in the logging portion of the ARMI docs. It was actually fairly hard to read.
(Also, our code coverage badge in the main README wasn't updating any more due to a GitHub caching issue, so I fixed that.)