Validate YAML Files #495
Merged
Validate YAML Files #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakehader
reviewed
Dec 1, 2021
jakehader
reviewed
Dec 1, 2021
jakehader
reviewed
Dec 1, 2021
ntouran
reviewed
Dec 1, 2021
ntouran
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, I believe we turned off validation of YAML files, but kept the validation on XML files. I'm not sure when, how, or why. But this PR applies the XML validation we have been doing the past ~two years to the YAML files.
This will probably raise some warnings for people that they don't expect. It might make people take a closer look at their materials, for instance. But it will also straight up throw warnings, and prompt users to acknowledge if there are bogus settings going into a file (see my unit test for an example).
This PR closes this ticket: #461