Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing Math Utilities #584

Merged
merged 8 commits into from
Feb 23, 2022
Merged

Conversation

john-science
Copy link
Member

Description

This is just a code reorg to move a lot of math-specific utilities from armi/utils/__init__.py to a more predictable location in armi/utils/mathematics.py.

I put in some imports so this won't break backwards compatibility.


Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@john-science john-science added architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority labels Feb 22, 2022
Copy link
Member

@ntouran ntouran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update. thanks!

@john-science john-science merged commit 53d64ab into terrapower:master Feb 23, 2022
@john-science john-science deleted the mv2math branch February 23, 2022 04:11
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants