Add validation to settings using schema

[keckler]

Description

Add validation to many of the framework settings using the schema parameter and voluptuous. Mainly validating ranges and sizes of user inputs.

---

Checklist

• The code is understandable and maintainable to people beyond the author.
• Tests have been added/updated to verify that the new or changed code works.
• There is no commented out code in this PR.
• The commit message follows good practices.
• All docstrings are still up-to-date with these changes.

If user exposed functionality was added/changed:

• Documentation added/updated in the doc folder.
• New or updated dependencies have been added to setup.py.

[john-science]

I love that you filled out the ranges.

I'm not sure that using "DB" over "database" was really a problem before. But I don't have strong opinions.

I liked that you filled out some missing labels and descriptions.

[keckler]

This is in response to #580

[keckler]

Hm... The test_kineticsParameterAssignment test is failing. I see why. Lemme change.

[jakehader]

@keckler, the changes look good to me, but there are still some failing unit tests that should be addressed before merging in.

[keckler]

Yes, I know, a few things still need to be addressed here. I was waiting before for the XML stuff to be removed from the framework, and then I got distracted. This is still on my radar though!

[keckler]

Alright, well even though I wanted to figure a way around #669, I didn't. So the schemas look kinda gross sometimes, but whatever.

[keckler]

@jakehader @john-science
Finally, I think this PR is ready. Sorry for taking so long on it!

[john-science]

I will merge this tonight: we had a couple of other merges today, and I just want to give some time for all of the downstream repos to run their CI separately.

Thanks!

[keckler]

Yeah, thanks for the suggestions both of you. I haven't given up on this, just gotten a little busy with other things. Will come back to it.

…

On Tue, Mar 15, 2022 at 11:34 AM John Stilley ***@***.***> wrote: @jakehader <https://github.com/jakehader> I haven't seen the vol.Coerce <https://www.programcreek.com/python/example/104567/voluptuous.Coerce> before, that's another good pathway. I haven't actually seen people use voluptuous before, it's all new to me. But it sounds like we have a couple of pathways forward. Awesome. — Reply to this email directly, view it on GitHub <#595 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFHRHMGXL2A2UT3YDGECJWLVAC3YHANCNFSM5QQGHOYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>