Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Snapshot DB issue #692

Merged
merged 6 commits into from
Jun 1, 2022
Merged

Fixing Snapshot DB issue #692

merged 6 commits into from
Jun 1, 2022

Conversation

john-science
Copy link
Member

Description

This PR is in reference to #691

The bug should be addressed, though building a proper unit test for the feature has proved tricky.

Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@john-science john-science linked an issue Jun 1, 2022 that may be closed by this pull request
with default nCycles (nCycles=1) database writes at cycle 0 are suppressed in snapshots #691
Closed
onufer
onufer reviewed Jun 1, 2022
View reviewed changes
armi/cases/case.py Outdated Show resolved Hide resolved
onufer
onufer approved these changes Jun 1, 2022
View reviewed changes
armi/operators/snapshots.py Outdated Show resolved Hide resolved
@john-science john-science merged commit 3755ffd into terrapower:master Jun 1, 2022
@john-science john-science deleted the snapshot_db branch June 1, 2022 22:10
mgjarrett pushed a commit to mgjarrett/armi that referenced this pull request Jun 10, 2022
@john-science @mgjarrett
Fixing Snapshot DB issue (terrapower#692)
7147c23
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Fixing Snapshot DB issue (terrapower#692)
6f03f9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onufer onufer onufer approved these changes

@ntouran ntouran Awaiting requested review from ntouran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with default nCycles (nCycles=1) database writes at cycle 0 are suppressed in snapshots
2 participants
@john-science @onufer