Update to armi.tests.detailedAxialExpansion
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - adding shield block to fuel assemblies and additional duct to control assemblies - improves realism to fuel assemblies and symmetry to control - also varying the height of the fuel assemblies based on position. Axial shield + fuel blocks are tallest for inner core fuel assemblies (followed by middle and outer core, respectively).
Summary: - Is hopefully more intuitive now. - reordered block definitions to better match the order in which they're actually built by the armi.reactor.blueprints system. Note, this is determined by the assembly definitions. The assemblies are built in the order they are defined and the blocks from bottom to top.
- custom materials do not thermally expand, so test_coldAssemblyHeight needs to be adjusted. - also see armi.reactor.components.component.py::Component::getThermalExpansionFactor
- it helps to know which assembly you're dealing with when this errMsg rears its head.
john-science
approved these changes
Jun 5, 2022
albeanth
added a commit
to albeanth/armi
that referenced
this pull request
Jun 6, 2022
5 tasks
john-science
pushed a commit
that referenced
this pull request
Jun 6, 2022
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
Summary: - adding shield block to fuel assemblies and additional duct to control assemblies - improves realism to fuel assemblies and symmetry to control - also varying the height of the fuel assemblies based on position. Axial shield + fuel blocks are tallest for inner core fuel assemblies (followed by middle and outer core, respectively). - complete overhaul of blueprints structure - reordered block definitions to better match the order in which they're actually built by the armi.reactor.blueprints system. Note, this is determined by the assembly definitions. The assemblies are built in the order they are defined and the blocks from bottom to top.
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
armi.tests.detailedAxialExpansionblueprintsarmi.tests.refSmallCoreGrid.yamldoes not actually utilize all the different assembly types. So a new core grid is introduced to utilize all of the assemblies defined in the blueprints.test_axialExpansionChanger.pyneeded to be adjusted.Checklist