Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding THaverageSlugTemp parameter #695

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

albeanth
Copy link
Member

@albeanth albeanth commented Jun 3, 2022

A T/H parameter that is useful for storing temperatures of the slugs/pins for non-fuel geometries.

@dlangewisch

Description


Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

- useful for non-fuel pinned geometries
@john-science john-science self-requested a review June 3, 2022 21:22
@john-science john-science added the enhancement New feature or request label Jun 3, 2022
@albeanth
Copy link
Member Author

albeanth commented Jun 3, 2022

Unit testing of armi/physics/thermalHydraulics is (well, seems) to be taken care of in unit testing outside of this directory. Likely in the form of reading a settings file (...somewhere...). So though there isn't a test directory, the coverage for this file is 100% before and after the changes proposed in this PR.

Within armi/physics:

> coverage run -m pytest
> coverage report -m --include=./thermalHydraulics/**
Name                              Stmts   Miss  Cover   Missing
---------------------------------------------------------------
thermalHydraulics\__init__.py         1      0   100%
thermalHydraulics\const.py            1      0   100%
thermalHydraulics\parameters.py      80      0   100%
thermalHydraulics\plugin.py          21      1    95%   50
thermalHydraulics\settings.py         9      1    89%   46
---------------------------------------------------------------
TOTAL                               112      2    98%

@john-science john-science merged commit c29a9f8 into terrapower:master Jun 3, 2022
@albeanth
Copy link
Member Author

albeanth commented Jun 3, 2022

(just for posterity)

This PR was rolled back as the parameter was quickly deemed unnecessary.

I was that guy today.

@albeanth albeanth deleted the THaverageSlugTemp branch June 7, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants