Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused imports #751

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Removing unused imports #751

merged 1 commit into from
Jul 6, 2022

Conversation

john-science
Copy link
Member

Description

We have a lot of unused imports in ARMI. This is just me cleaning that out.

Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Jul 6, 2022
opotowsky
opotowsky approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gorgeous cleanup, and easy approval!

@john-science john-science merged commit 5a20a05 into terrapower:main Jul 6, 2022
@john-science john-science deleted the rm_unused branch July 6, 2022 15:06
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Removing unused imports (terrapower#751)
bde4e01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

@keckler keckler Awaiting requested review from keckler

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @opotowsky