Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating case compare to match new signature #779

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Updating case compare to match new signature #779

merged 1 commit into from
Jul 19, 2022

Conversation

john-science
Copy link
Member

Description

@Nebbychadnezzar points out that in suite.py, there is a call to Case.compare() using the old method signature, even though that was clean up recently. This PR fixes this problem.

Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@john-science john-science added the bug Something is wrong: Highest Priority label Jul 19, 2022
Nebbychadnezzar
Nebbychadnezzar approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@Nebbychadnezzar Nebbychadnezzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A most excellent PR.

@john-science john-science removed the request for review from opotowsky July 19, 2022 00:25
@john-science john-science merged commit 6b94942 into terrapower:main Jul 19, 2022
@john-science john-science deleted the fix_case_compare branch July 19, 2022 00:25
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Updating case compare to match new signature (terrapower#779)
4c53601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nebbychadnezzar Nebbychadnezzar Nebbychadnezzar approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @Nebbychadnezzar