Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mesh converter for axially nodalization with block flags and XS IDs #780

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

jakehader
Copy link
Member

Add new mesh converter for HexToRZTheta reactor conversions that examines the state of the core and determines the axially nodalization based on the flags and XS IDs. This is useful for dynamically creating an RZ reactor core model that minimizes the number of material regions while preserving the XS ID assignments by users and with burnup.

Description


Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

If user exposed functionality was added/changed:

  • Documentation added/updated in the doc folder.
  • New or updated dependencies have been added to setup.py.

examines the state of the core and determines the axially nodalization
based on the flags and XS IDs.
@jakehader jakehader added the enhancement New feature or request label Jul 19, 2022
@jakehader jakehader requested a review from ntouran July 19, 2022 20:09
Comment on lines +400 to +401
else:
if self._axialMeshConversionType == self._MESH_BY_AXIAL_COORDS:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time, I think this "else" and "if" could be combined into an "elif".

@john-science john-science merged commit f486c2b into main Jul 19, 2022
@john-science john-science deleted the meshConverter branch July 19, 2022 21:22
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants