-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix snap list for blueprints assemblies #783
Conversation
@john-science we are still debugging some issues when loading from a database and the treatment of updateAxialMesh. @onufer will update this once we have resolved those issues and the PR will be ready. |
@john-science - The changes here are good and help us get DB loading operational. There are a lot of complexities with the mesh treatment at different loading conditions (from settings/blueprints or from a database) that we need to resolve throughout the code base. This is a good first step and patch for the on-going work here, but @albeanth and I will work together on prioritizing the issues more globally and then proposing an "ARMI mesh refactor/clean-up" project that will help us to get better integration testing for the framework and unit testing on the various ways we can initialize a system model. I will leave this up to you or @onufer to Squash and Merge, as I don't want to jump ahead without your review and making sure that it doesn't have some impacts on the current in-progress PRs. |
@jakehader Also, Tony and I were talking yesterday and it sounds like there has not been much/any testing of the new detailed axial expansion features when it comes to reading from a Database. So I think that needs to be tested at some point, wherever that fits on the schedule. |
I have been loading axially-expanded cores from the DB. I haven't looked in super detail at it, but it appears to be working in the sense that the assemblies are expanded. |
This is not with |
Description
Fixing snap list for blueprints assemblies
Checklist