Fix bug in rotatePins() #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assignment for pinLocation was broken. I am not sure why it was set
up the way it was, but it was using ParameterCollection.__setitem__() and
setting the `name` argument to the tuple ("pinLocation", pinNum). That
throws a TypeError from setattr(), which gets caught and then instead
makes an assigment to self._hist because `name` is a tuple. That is
definitely not what is intended.
|
Looping in fellow pin aficionado @mgjarrett |
mgjarrett
reviewed
Aug 24, 2022
jakehader
approved these changes
Aug 24, 2022
|
Can someone help me out here? What happens when you call For those users... does |
|
It's only on the If you do have a |
AH! I'm just blind. (And probably sleep deprived.) Thanks! |
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
The assignment for pinLocation was broken. I am not sure why it was set up the way it was, but it was using ParameterCollection.__setitem__() and setting the `name` argument to the tuple ("pinLocation", pinNum). That throws a TypeError from setattr(), which gets caught and then instead makes an assigment to self._hist because `name` is a tuple. That is definitely not what is intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The assignment for
pinLocationin therotatePinsmethod is broken. I am not sure why it was set up the way it was, but it was usingParameterCollection.__setitem__()to make the assignment. The syntax used ended up setting thenameargument to the tuple("pinLocation", pinNum). That throws aTypeErrorfromsetattr(), which gets caught within__setitem__()and then instead makes an assignment toself._hist(whereselfis the parameter collection) becausenameis a tuple. That is definitely not what is intended.This PR fixes this bug. Doc string improvements have also been attempted.
Checklist
docfolder.setup.py.