Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Code Coverage to Utils #884

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

john-science
Copy link
Member

Description

Just adding a little code coverage.

In the process, my pylint tripped up on a bunch of unit tests, so I fixed that too.


Checklist

  • This PR has only one purpose or idea. (Well, one idea plus cleanup.)
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added cleanup Code/comment cleanup: Low Priority testing Related to tests labels Sep 18, 2022
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than addressing Tony's comment (which was an astute observation!) I think this PR looks good.

@john-science
Copy link
Member Author

@opotowsky @albeanth
Thanks ya'll.

I realize I do too much cleanup in my PRs. At the time, my little pylint lines in this one seemed so minor. But I will try to do better about splitting this PR into two in the future.

Thanks!

@john-science john-science merged commit f0d27e7 into terrapower:main Sep 20, 2022
@john-science john-science deleted the code_cov_20220916 branch September 20, 2022 15:10
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Also, adding some pylint disable lines to unit test files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants