Fix burnup-dependent reaction rates #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor The primary purpose of this commit is to fix the `getReactionRates()` methods on the `Block` and `Component` classes to account for burnup-dependent cross-sections. This is completed primarily by changing the underlying `getReactionRateDict()` method to accept the entire library suffix instead of just the first letter of the suffix (i.e. "AA" or "AB" instead of just "A"). In the process, it was seen that a refactor could be achieved where the two classes could share the method of the parent instead of implementing their own, since they effectively do the same thing. This was accomplished by generalizing the calls in the method and moving that method into the `Composite` class.
john-science
approved these changes
Sep 30, 2022
|
Alright @john-science , I moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary purpose of this commit is to fix the
getReactionRates()methodson the
BlockandComponentclasses to account for burnup-dependent cross-sections, as was brought up in #813 .This is completed primarily by changing the underlying
getReactionRateDict()method to accept the entire library suffix instead of just the first letter of
the suffix (i.e. "AA" or "AB" instead of just "A").
In the process, it was seen that a refactor could be achieved where the two classes could share the method of the parent instead of implementing their own, since they effectively do the same thing. This was accomplished by generalizing the calls in the method and moving that method into the
Compositeclass.Unit tests have also been updated.
I looked around, and do not believe that the change in the
getReactionRateDict()signature should impact anybody. And even if it does, this is a necessary change because this was previously a bug.In terms of impact of this bug-fix on physics results, I only know of two potential impacts, both on internal projects. I have already reached out to both of those projects individually.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.