Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the detailedAxialExpansion category to the fast flux parameter #928

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

jakehader
Copy link
Member

Description

The detailedAxialExpansion category was not applied to the fast flux block parameter and therefore mapping in the UniformMeshConverter was missing this parameter when data was being transferred. We have many parameter assignments in the framework that are not correct and there needs to be more complete audit of the parameter system, but this is just one that was reported.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@jakehader jakehader added the bug Something is wrong: Highest Priority label Oct 5, 2022
@jakehader jakehader requested review from john-science and onufer and removed request for john-science October 5, 2022 19:17
@jakehader jakehader merged commit 2f52989 into main Oct 5, 2022
@jakehader jakehader deleted the fastFlux branch October 5, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants