Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones overhaul updates #938

Merged
merged 5 commits into from
Oct 12, 2022
Merged

Zones overhaul updates #938

merged 5 commits into from
Oct 12, 2022

Conversation

joshuavictorchen
Copy link
Contributor

@joshuavictorchen joshuavictorchen commented Oct 12, 2022

Description

Merge the working zones-related branches into one.

  1. Update reactors module such that a Core is given an empty Zones upon instantiation (instead of None)
  2. Remove references to zoning strategy hooks and reactors.buildZones: zones will be implemented in downstream applications via Interfaces
  3. Move buildManualZones function to the Core class (if called, then Core.zones is set up using the zoneDefinitions case setting

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2022

CLA assistant check
All committers have signed the CLA.

@joshuavictorchen
Copy link
Contributor Author

Added unit tests to clear the coverage checks, which led me to discover and fix a bug with Zones.getAllLocations. Hopefully we get the green checks, now :)

@john-science john-science added enhancement New feature or request architecture Issues related to big picture system architecture labels Oct 12, 2022
@john-science john-science merged commit 0dd52c9 into zones_overhaul Oct 12, 2022
@john-science john-science deleted the zones_overhaul_updates branch October 12, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issues related to big picture system architecture enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants