Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix armi/materials/b4c.py::density3 to utilize TD frac #942

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Fix armi/materials/b4c.py::density3 to utilize TD frac #942

merged 5 commits into from
Oct 20, 2022

Conversation

albeanth
Copy link
Member

Description

B4C was having issues with density conservation and component expansion. Turns out, density3 was not including the theoretical density defined in armi/materials/b4c.py. This PR resolves:

  1. resolves this
  2. updates test_components.py::TestComponentExpansion to loop over multiple materials. The additional cost is minimal and covers common important reactor materials.
    • also includes minimal clean up for clarity improvements.

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@albeanth
fix B4C density3 to utilize TD frac
697de3a 
- also update test_components::TestComponentExpansion to loop over multiple materials. additional cost is minimal and covers common important reactor materials.
@albeanth albeanth added bug Something is wrong: Highest Priority testing Related to tests labels Oct 17, 2022
@albeanth albeanth mentioned this pull request Oct 17, 2022
Closed
7 tasks
@albeanth
simplify b4c.py::density + density3 to improve coverage
20ed76b 
- b4c.p.theoreticalDensityFrac gets set when the component is initialized so it will always be set. no need to check if it's set.
john-science
john-science approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Do you have good eyes on what downstream projects this will affect?

@albeanth
Copy link
Member Author

Sure.

Do you have good eyes on what downstream projects this will affect?

Should be good to go.

@john-science john-science merged commit 37f5479 into terrapower:main Oct 20, 2022
@albeanth albeanth deleted the compExp_UnitTest_Update branch October 20, 2022 19:55
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@albeanth @scottyak
Fixing b4c material density (terrapower#942)
7e03e32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onufer onufer onufer approved these changes

@john-science john-science john-science approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority testing Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albeanth @john-science @onufer