-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use r.core.axialMesh() for uniform mesh. #959
Conversation
When making a uniform mesh assembly in the UniformMeshConverter, the freshly minted assembly does not have any submesh (i.e., b.p.axMesh == 1). Homogenizing onto the refAssem's block mesh [r.core.refAssem.getAxialMesh()] poses problems if some blocks in the refAssem have a submesh. r.core.axialMesh() contains the computational neutronics mesh, which has all of the mesh subdivisions; this is the mesh that should be used for makeAssemWithUniformMesh().
I ran the tests locally and they passed, so... I don't know? The 3.7, 3.8, 3.9, and 3.10 unit tests all pass, but the "ARMI Windows tests" fails. I can't think of anything changed here that would be affecting the failing test. |
@mgjarrett I would guess that the issue is a race condition somewhere in
My assumption here is if you ran the test again, the bug would not appear. I'll be honest, I've run the ARMI unit tests thousands of times, and not seen this one. So if I see it a second time, I'll have to fix it. But I'm hoping this is a one-off bug with the Windows file system.
|
Description
When making a uniform mesh assembly in the
UniformMeshConverter
, the freshly minted assembly does not have any submesh (i.e.,b.p.axMesh = 1
).armi/armi/reactor/converters/uniformMesh.py
Line 380 in bc3cf47
Creating a uniform mesh assembly with the refAssem's block mesh (
r.core.refAssem.getAxialMesh()
) poses problems if some blocks in therefAssem
have a submesh (i.e.,b.p.axMesh > 1
), because the uniform mesh assembly will not have a submesh.r.core.p.axialMesh()
contains the computational neutronics mesh, which has all of the mesh subdivisions; this is the mesh that should be used formakeAssemWithUniformMesh()
.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.