Moving FuelHandler Algorithms to separate files #962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
FuelHandler.py
file has a ton of algorithms of various kinds that are very specific to hex assembly reactors. This has caused lots of confusion for people who are implementing some sort of fuel handling logic. It also muddies the waters significantly between general fuel handling logistics code and detailed hex assembly algorithms.The code in the old
fuelHandler.py
has been broken up into three files:fuelHandlers.py
- hasFuelHandler
classhexAssemblyFuelMgmtUtils.py
- Assorted shuffling and misc algorithms for managing hex assembly reactors.assemblyRotationAlgorithms.py
- Rotation algorithms called byFuelHandler.outage()
. (This does seem to be specific to assembly/hex-assembly reactor, butFuelHandler.outage()
will only call it if a particular setting is used, which does an okay job of keeping theFuelHandler
class from being specific to hex assemblies.)Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.