Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamo DB table creation #43

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Dynamo DB table creation #43

merged 9 commits into from
Nov 14, 2023

Conversation

jeetpatgiri
Copy link
Contributor

@jeetpatgiri jeetpatgiri commented Nov 13, 2023 •
edited by vmilovanovicc
Loading

  • added release service database schema
  • added unit test to test registering release service with the grpc server
  • added release service endpoint
  • resolved requested changes
  • fixed an error found during initializing dynamodb tables, checking error types prevents tables from being created, more details in Jira

deployed on a testing environment - Release v0.0.60-CIEDEV-2141.2
image

odelanno
odelanno requested changes Nov 13, 2023
View reviewed changes
cmd/gateway.go Outdated Show resolved Hide resolved
internal/release/services/release/release.go Outdated Show resolved Hide resolved
internal/release/services/release/release.go Show resolved Hide resolved
internal/release/services/release/release.go Outdated Show resolved Hide resolved
internal/release/services/release/release.go Outdated Show resolved Hide resolved
odelanno
odelanno previously approved these changes Nov 14, 2023
View reviewed changes
@ilijad1
Copy link
Contributor

ilijad1 commented Nov 14, 2023

We need to add the semver package fix that @vmilovanovicc introduced to this PR.

ilijad1
ilijad1 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ilijad1 ilijad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and deployed on terrarium green cluster. Works as expected.

cmd/gateway.go Outdated Show resolved Hide resolved
@vmilovanovicc vmilovanovicc merged commit 86720d8 into main Nov 14, 2023
1 check passed
@vmilovanovicc vmilovanovicc deleted the CIEDEV-2141 branch November 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilijad1 ilijad1 ilijad1 approved these changes

@vmilovanovicc vmilovanovicc vmilovanovicc approved these changes

@odelanno odelanno odelanno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeetpatgiri @ilijad1 @odelanno @vmilovanovicc