Upgrade to OpenLayers v6.x #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2019
dnlkoch
reviewed
Oct 8, 2019
| @@ -48,10 +48,6 @@ describe('FileUtil', () => { | |||
| map = TestUtil.createMap(); | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| TestUtil.removeMap(map); | |||
| }); | |||
There was a problem hiding this comment.
Map removal leads to the following error, cause renderer seems to be null at the moment where the test tries to access the map then:
TypeError: Cannot read property 'renderFrame' of null
at Map.PluggableMap.renderFrame_ (node_modules/ol/src/PluggableMap.js:1292:20)
at Map.<anonymous> (node_modules/ol/src/PluggableMap.js:198:12)
at Timeout.callback [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:678:19)
The error is possibly due to openlayers/openlayers#9637
For now, I've commented the afterEach test block and added a TODO to investigate it later.
I've also added the corresponding issue --> #150 .
| - `value` **[number](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Number)** Value to be zerofilled. | ||
|
|
||
| Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** converted value with leading zero if necessary. | ||
|
|
There was a problem hiding this comment.
Docs are available here and will be updated automatically. I suggest to delete the docs from the README completely (in a follow up MR).
There was a problem hiding this comment.
Ok, will be done in a separate MR
This was referenced Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Upgrades
ol-utilpackage to be able to work witholv 6.x and higher.Additionally updated autogenerated API documentation.
Please review @terrestris/devs