Add support for OlSourceImageWMS to getLegendGraphicUrl method (for ol4) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjansen
approved these changes
Sep 4, 2018
src/MapUtil/MapUtil.js
Outdated
| @@ -304,11 +304,14 @@ export class MapUtil { | |||
| Logger.error('Invalid input parameter for MapUtil.getLegendGraphicUrl.'); | |||
| return; | |||
| } | |||
| const isTiledWMS = layer.getSource() instanceof OlSourceTileWMS; | |||
There was a problem hiding this comment.
better
const src = layer.getSource();
if(!src) {
return undefined;
}
const isTiledWMS = src instanceof OlSourceTileWMS;
const isImageWMS = !isTiledWMS && src instanceof OlSourceImageWMS;then the if below gets trivial and more cases can easily be added IMO
| expect(legendUrl).toContain(requestParam); | ||
| expect(legendUrl).toContain(formatParam); | ||
| describe('returns a getLegendGraphicUrl from a given layer', () => { | ||
| it('… for a tiled Layer', () => { |
KaiVolland
force-pushed
the
getlegend-nontiled
branch
from
f3c64b0
to
61da93d
Compare
KaiVolland
changed the title
KaiVolland
force-pushed
the
getlegend-nontiled
branch
from
61da93d
to
5ed4a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
OlSourceImageWMSlayers to thegetLegendGraphicUrlmethod.