Add components for floating map logo and scale combo #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
approved these changes
Sep 6, 2017
src/Map/ScaleCombo/ScaleCombo.jsx
Outdated
| * @param {type} resolution Description | ||
| * @param {type} mv Description | ||
| * | ||
| * @return {type} Description |
src/Map/ScaleCombo/ScaleCombo.jsx
Outdated
| * @param {type} resolution Description | ||
| * @param {type} mv Description | ||
| * | ||
| * @return {type} Description |
| import FloatingMapLogo from './FloatingMapLogo.jsx'; //@react-geo@ | ||
|
|
||
| render( | ||
| <FloatingMapLogo imageSrc="logo.png"/>, |
There was a problem hiding this comment.
Can we make use of a image-loader here?
There was a problem hiding this comment.
Alright, use image loader in 0607940
src/Map/ScaleCombo/ScaleCombo.jsx
Outdated
| let scale = MapUtils.getScaleForResolution(resolution, mv.getProjection().getUnits()); | ||
| let roundScale = Math.round(scale); | ||
| let option = <Option key={roundScale.toString()} value={roundScale.toString()}>1:{roundScale.toLocaleString()}</Option>; | ||
| this.props.scales.push(option); |
There was a problem hiding this comment.
Props are immutable inside the component. Please make use of the state instead.
src/Map/ScaleCombo/ScaleCombo.jsx
Outdated
| * | ||
| * @return {Element} Option element for provided zoom level | ||
| */ | ||
| getVal (zoom) { |
There was a problem hiding this comment.
Can we rename this to something more meaningful?
There was a problem hiding this comment.
Renamed to determineOptionKeyForZoomLevel in bef0bbd
|
Top! Great addition! |
ahennr
force-pushed
the
add-maplogo-and-scale-combo
branch
from
25428dc
to
315d2ae
Compare
|
Thx for review @dnlkoch . Will merge as soon as all checks are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
FloatingMapLogoandScaleCombocomponents.In addition,
MapUtilis included here as well beside methodbuildLayersFromInitialState(see #12)