Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to OpenLayers v5 #631

Merged
merged 35 commits into from
Sep 6, 2018
Merged

Upgrade to OpenLayers v5 #631

merged 35 commits into from
Sep 6, 2018

Conversation

marcjansen
Copy link
Member

@marcjansen marcjansen commented May 7, 2018 •
edited
Loading

REFACTORING

Description:

This supersedes #606 (this is a rebased version for which the build passes.)

Let's stay tuned and be compatible with prospective avaliable upgraded OpenLayers v5.x! 🤸‍♂️

This PR contains first steps to get married with newest ol which is currently avaliable as v5.0.0-beta.10.

Most important changes:

  • all ol classes imports are in camelcase now
  • for the following classes the named imports for affected functions are used now:
    • ol/easing
    • ol/proj
    • ol/proj/proj4
    • ol/extent
    • ol/interaction/Draw
    • ol/events/Condition
    • ol/Observable
    • ol/sphere
    • ol/format/Filter

Upgrade considers notes mentioned here and here.

Enjoy! 🍍

Fixes #515

@marcjansen marcjansen changed the title Ol5 upgrade [WIP] Upgrade to OpenLayers v5 May 7, 2018
@marcjansen marcjansen mentioned this pull request May 7, 2018
Closed
@marcjansen marcjansen mentioned this pull request May 11, 2018
Closed
@marcjansen marcjansen force-pushed the ol5-upgrade branch 2 times, most recently from 7781f35 to 0a33662 Compare May 16, 2018 16:03
@marcjansen
Copy link
Member Author

The build currently fails on Node 10, but passes locally for me:

image

This needs more investigation.

@dnlkoch
Copy link
Member

dnlkoch commented May 23, 2018

I recognized the failing test in another PR as well and I think it's not related to the changes made here. Dealing with setTimeout() with a fixed timeout is always tricky…

@dnlkoch
Copy link
Member

dnlkoch commented May 24, 2018

Apparently #667 fixes the failing tests. It's almost the same change as introduced here (thanks @marcjansen), but it also overhauls the tests in the CircleMenuItem spec.

@dnlkoch dnlkoch mentioned this pull request May 24, 2018
Merged
@marcjansen marcjansen force-pushed the ol5-upgrade branch 2 times, most recently from b1f64ca to cc1a147 Compare May 24, 2018 10:09
@KaiVolland KaiVolland mentioned this pull request Jun 28, 2018
Closed
@annarieger
Copy link
Member

annarieger commented Jul 4, 2018 •
edited
Loading

ol5 (v5.0.0) has been released 8 days ago 👏
I'll try to tackle still existing conflicts tonight and prepare this PR for merging..

@marcjansen
Copy link
Member Author

I'll try to tackle still existing conflicts tonight

That is nice, thanks.

and prepare this PR for merging.

Before merging we should release. The first release which contains this PR shold IMO be a major release with clear advice what is needed in projects to make use of that new release.

Thanks.

@annarieger
Copy link
Member

I totally agree with all your points @marcjansen. That's why I wrote "prepare for merging".. This doesn't mean that I'm gonna do it directly 😉

@annarieger annarieger force-pushed the ol5-upgrade branch 3 times, most recently from c80bbc9 to a76a54c Compare July 5, 2018 09:21
@annarieger annarieger mentioned this pull request Jul 5, 2018
Closed
@annarieger annarieger changed the title [WIP] Upgrade to OpenLayers v5 Upgrade to OpenLayers v5 Jul 5, 2018
@annarieger
Copy link
Member

PR is ready for review now. It's rebased to include all significant changes from master branch and supports currently latest avaliable release v5.0.2 of ol.

As @marcjansen mentioned above, we should mandatory release react-geo due to breaking changes in the API before this one is merged.

@KaiVolland
Copy link
Member

Is there a general update strategy? New features only to for OL5?

@marcjansen
Copy link
Member Author

marcjansen commented Jul 5, 2018 •
edited
Loading

Is there a general update strategy? New features only to for OL5?

@KaiVolland See description:

Upgrade considers notes mentioned here and here.

Let's just release a new minor with the latest changes and then release a new major with this in. The major is justifuied due to changed peer dependency. release notes should include a big marker linking to the above documents.

@KaiVolland
Copy link
Member

Sry my question wasn't precise enough.
I wanted to know how react-geo should handle new features of react-geo. So will we continue to support v8 (ol4) or will we just add new features to >v9 (ol5). Bugs should be fixed for both i think.

annarieger and others added 18 commits September 6, 2018 10:03
@annarieger @KaiVolland
use named import for fromLonLat function of ol/proj class
9bf6a35
@annarieger @KaiVolland
use named imports for ol/extent class and make use of register() func…
003fd3e 
…tion of ol/proj/proj4
@annarieger @KaiVolland
use named imports fro unByKey function of ol/observable
1bbd78f
@annarieger @KaiVolland
use named import for transformExtent function of ol/proj
4921add
@annarieger @KaiVolland
fix tests for measure button
bbee763
@marcjansen @KaiVolland
Use OpenLayers v5
ba6ecff
@marcjansen @KaiVolland
Use uppercase import for ol/Map in ScaleCombo
f8492f7 
This was introduced with 4419619 via #649,
which occured after the original import cleanup for OpenLayers@5
compatibility.
@annarieger @KaiVolland
use ol@5.0.2
7a498e5
@dnlkoch @KaiVolland
Remove rebase artifacts
6389afb
@dnlkoch @KaiVolland
Fix ol import paths
031e6df
@dnlkoch @KaiVolland
Upgrade ol dependency to 5.1.3
729a847
@dnlkoch @KaiVolland
Remove extra whitespaces
32f0457
@dnlkoch @KaiVolland
Test for decimals
668b60c
@dnlkoch @KaiVolland
Add development notes for linked ol-based packages, e.g. @terrestris/…
bbaa374 
…ol-util
@dnlkoch @KaiVolland
Update ol-util dependency
3ca0abc
@dnlkoch @KaiVolland
Update ol dependency
7da38df
@KaiVolland
Lintfix
8cc6e1b
@KaiVolland
Several dependency upgrades
1cc43f4
ahennr
ahennr approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@ahennr ahennr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, plz merge

@KaiVolland KaiVolland merged commit c54dc12 into master Sep 6, 2018
@marcjansen marcjansen deleted the ol5-upgrade branch September 6, 2018 15:53
hblitza pushed a commit that referenced this pull request Oct 19, 2022
@simonseyock
Merge pull request #631 from terrestris/fix-typings
86e1471 
fix: type errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbllmnn hwbllmnn hwbllmnn approved these changes

@dnlkoch dnlkoch dnlkoch approved these changes

@weskamm weskamm weskamm approved these changes

@annarieger annarieger annarieger approved these changes

@ahennr ahennr ahennr approved these changes

Assignees
No one assigned
Labels
breaking change enhancement feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marcjansen @dnlkoch @annarieger @KaiVolland @hwbllmnn @weskamm @ahennr