Add ObjectUtil helper class #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjansen
force-pushed
the
port-utils
branch
from
cf4b04f
to
07f5886
Compare
marcjansen
force-pushed
the
port-utils
branch
from
07f5886
to
c897a6d
Compare
Closed
|
Basically 👍 However, |
KaiVolland
requested changes
Sep 6, 2017
src/Util/ObjectUtil.js
Outdated
| var queryMatch; | ||
|
|
||
| if (!isString(queryKey)) { | ||
| // TODO Replace with new logger after logger implementation |
There was a problem hiding this comment.
As we got a Logger now please address this util.
src/Util/ObjectUtil.js
Outdated
| return false; | ||
| } | ||
| if (!isObject(queryObject)) { | ||
| // TODO Replace with new logger after logger implementation |
There was a problem hiding this comment.
As we got a Logger now please address this util.
|
@KaiVolland I have addressed your two comments, would you have another look?
OI think before refactoring we should add it as is. If you want me to do it, I can of course go ahead and rewrite this. |
KaiVolland
approved these changes
Sep 7, 2017
hblitza
pushed a commit
that referenced
this pull request
Oct 19, 2022
…il-0.1.1 Update @terrestris/base-util to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
ObjectUtilhelper class from a client project. It is ported with the minimum needed changes, and with additional tests so that coveralls is happy.Please review.