Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is is possible to have callbacks when uploading objects? #60

Closed
treuille opened this issue May 21, 2018 · 6 comments
Closed

Is is possible to have callbacks when uploading objects? #60

treuille opened this issue May 21, 2018 · 6 comments
Assignees

Comments

@treuille
Copy link

Might it be possible to get progress callbacks for upload_file and upload_fileobj as in boto3?

(This issue was created at the recommendation of @terrycain in aio-libs/aiobotocore#584.)

Thank you!

@terricain
Copy link
Owner

terricain commented May 21, 2018

Yeah, the solution would be for me to change the current upload_fileobj to do a multipart upload instead of a put_object.

Will work on that in the next couple of days

@terricain
Copy link
Owner

Can you try the multipart_upload_60 branch. It "should" have the required fixes... also it knows none of the error conditions when doing multipart uploads as I don't know what they would be so have just left in a default "404" type error for now.

@treuille
Copy link
Author

@terrycain : Thank you so much for getting back so quickly. My team is on a tight deadline to deliver a feature and so I won't have time to play with this until next week. (We're just going to settle for no progress :/ for now.)

However, I will definitely check this out when we have a breather -- probably next week.

Thank you again for the rapid response. 💯

@terricain
Copy link
Owner

No problem, it technically works as I had some tests run on it but it'll sit in that branch until you can test it as I'd rather have someone who has real-life uses for it play around with it 😄

@treuille
Copy link
Author

treuille commented Jun 2, 2018 via email

@terricain
Copy link
Owner

Is fixed in v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants