Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument meta should be supplied as dictionary #320

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

JohnGiorgi
Copy link
Contributor

@JohnGiorgi JohnGiorgi commented Aug 5, 2022

The documentation specifies the meta argument to pt.IterDictIndexer as a dictionary mapping meta field names to their lengths, e.g.

iter_indexer = pt.IterDictIndexer("./index", meta={'docno': 20, 'text': 4096})

but the documentation examples break this into two list args, meta and meta_lengths

iter_indexer = pt.IterDictIndexer("./index", meta=['docno', 'text'], meta_lengths=[20, 4096])

I think this is a mistake? I am finding that my length arguments are not respected when passed similar to the documentation examples.

@cmacdonald cmacdonald merged commit f8161bc into terrier-org:master Aug 19, 2022
@cmacdonald
Copy link
Contributor

Good spot, thanks @JohnGiorgi

@JohnGiorgi JohnGiorgi deleted the patch-2 branch August 19, 2022 16:16
@cmacdonald cmacdonald added this to the 0.9 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants