-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to remove newline before tag close #85
Add flag to remove newline before tag close #85
Conversation
I have some mixed opinions about this option. Let me get back on this. |
I think this is fine. This is the shortest and non breaking fix can be done I guess. Just thinking out loud.
|
Definitely a good idea. I am currently unsure but afaik there were discussions regarding this for html-minifier. |
Thanks, will check it out. |
I would prefer this const endTagMatch = results[0].match(endTag)
const forceSameLine = endTagMatch && inlineTextTags(endTagMatch[1]) Its breaking, but it is the correct behaviour I think. May be for v7. |
I'm wondering what happened with the CI build. |
Yeah I was waiting for the same. I think it is the branch protection rule. checking |
Okay. Found it I guess. the workflow was waiting for approval to run for first time contributors. Since it is not approved for more than 30 days, It got expired. |
Ah, can we somehow trigeger a new build? Optionally we can maybe push a commit |
Pushed a small change. we can squash merge the PR. |
Making a release now. |
Published in v6.1.0 |
@lucamattiazzi thank you very much for your contribution 👍 |
thank you for your library! and thanks for approving&merging! |
creates a new flag that allows the user to avoid adding newlines before the closing tag in order to both solve issue #84 and not change how the library works
Fixes #84