Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jest #90

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Migrate to Jest #90

merged 3 commits into from
Nov 9, 2021

Conversation

sibiraj-s
Copy link
Collaborator

@sibiraj-s sibiraj-s commented Nov 8, 2021

Jest

Changes done.

  • switch to jest (test run in both node and jsdom environments)
  • remove grunt.

Closes #24

@DanielRuf DanielRuf changed the title Jest Switch to Jest Nov 8, 2021
@DanielRuf DanielRuf changed the title Switch to Jest Migrate to Jest Nov 8, 2021
package.json Outdated Show resolved Hide resolved
@sibiraj-s
Copy link
Collaborator Author

@DanielRuf . Can I have permissions for branch protection settings? or can you enable the following.

  • require pull request to pass the tests
  • require at-least one review to merge the PR?

@DanielRuf
Copy link
Contributor

@DanielRuf . Can I have permissions for branch protection settings? or can you enable the following.

* require pull request to pass the tests

* require at-least one review to merge the PR?

You are free to make these changes as needed. It's ok from my side.

@sibiraj-s
Copy link
Collaborator Author

@DanielRuf . Can I have permissions for branch protection settings? or can you enable the following.

* require pull request to pass the tests

* require at-least one review to merge the PR?

You are free to make these changes as needed. It's ok from my side.

Thanks.

@sibiraj-s
Copy link
Collaborator Author

Can you leave your approval if the changes are fine. I will merge it. No more changes in this PR.

@sibiraj-s sibiraj-s merged commit fae6707 into v7-dev Nov 9, 2021
@sibiraj-s sibiraj-s deleted the jest branch November 9, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants