All-in-one pull-request, see comment #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed MicroPython incompatible string building syntax. Added rudimentary push endpoint support.
…Python compatible.
Added MicroPython compatible enum support. (Maybe remove enums completely at some point) Removed MicroPython incompatible string builder.
… no satisfying websockets implementation for MicroPython.
added all mandatory fields to PrimaryBlock. made fields in PrimaryBlock public. moved PrimaryBlock creation from cbor into own method.
Renamed flags for expressiveness.
Reworked bundle representation.
Removed unnecessary helper methods.
Removed a wrong import.
…or() encoding method.
Removed a comment.
Improved repr of bundle and blocks. Added object generation/builder functions for PrimaryBlock, PayloadBlock, BundleAgeBlock, and HopCountBlock. Improved Bundle generation/creation.
…l_seconds) Fixed bug where wrong class was instantiated. (PreviousBlock -> PayloadBlock)
…rrent time as dtn timestamp.
teschmitt
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Thank you so much for your substantial contributions to this library! Your changes have made the code base significantly more mature and readable. Making it compatible with the MicroPython implementation is the cherry on top.
Please look over my suggested changes and let me know what you think. All of them are not critically important but would really round off the PR.
Co-authored-by: Thomas Schmitt <t.e.schmitt@gmail.com>
teschmitt
added a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simpler Flag class.
Adds a full bundle representation + object creation + (de-)serialization (without CRC and fragments support).
Added imports and modified dtn_rs_client.py to support Micropython.
fixed bug with timestamp deserialization and "now" timestamp creation.
fixed bug in dtn_ws_client.py that hindered a successful import.