Fix namespace collision attempt 2 #26

tesk9 · 2020-04-25T01:37:40Z

This is a MAJOR change.

---- ADDED MODULES - MINOR ----

    SolidColor
    SolidColor.Accessibility
    TransparentColor


---- REMOVED MODULES - MAJOR ----

    Color
    Color.Accessibility
    Color.Transparent


---- Palette.Cubehelix - MAJOR ----

    Changed:
      - type alias AdvancedConfig =
            { start : Color
            , rotationDirection : RotationDirection
            , rotations : Float
            , gamma : Float
            }
      + type alias AdvancedConfig =
            { start : SolidColor.SolidColor
            , rotationDirection : Palette.Cubehelix.RotationDirection
            , rotations : Basics.Float
            , gamma : Basics.Float
            }

      - generate : Int -> List Color
      + generate : Basics.Int -> List.List SolidColor.SolidColor

      - generateAdvanced : Int -> AdvancedConfig -> List Color
      + generateAdvanced :
            Basics.Int
            -> Palette.Cubehelix.AdvancedConfig
            -> List.List SolidColor.SolidColor



---- Palette.Generative - MAJOR ----

    Changed:
      - complementary : Color -> Color
      + complementary : SolidColor.SolidColor -> SolidColor.SolidColor

      - monochromatic : Float -> Color -> List Color
      + monochromatic :
            Basics.Float
            -> SolidColor.SolidColor
            -> List.List SolidColor.SolidColor

      - splitComplementary : Float -> Color -> ( Color, Color )
      + splitComplementary :
            Basics.Float
            -> SolidColor.SolidColor
            -> ( SolidColor.SolidColor, SolidColor.SolidColor )

      - square : Color -> ( Color, Color, Color )
      + square :
            SolidColor.SolidColor
            -> ( SolidColor.SolidColor
               , SolidColor.SolidColor
               , SolidColor.SolidColor
               )

      - tetratic : Float -> Color -> ( Color, Color, Color )
      + tetratic :
            Basics.Float
            -> SolidColor.SolidColor
            -> ( SolidColor.SolidColor
               , SolidColor.SolidColor
               , SolidColor.SolidColor
               )

      - triadic : Color -> ( Color, Color )
      + triadic :
            SolidColor.SolidColor
            -> ( SolidColor.SolidColor, SolidColor.SolidColor )



---- Palette.Tango - MAJOR ----

    Changed:
      - aluminum1 : Color
      + aluminum1 : SolidColor.SolidColor

      - aluminum2 : Color
      + aluminum2 : SolidColor.SolidColor

      - aluminum3 : Color
      + aluminum3 : SolidColor.SolidColor

      - aluminum4 : Color
      + aluminum4 : SolidColor.SolidColor

      - aluminum5 : Color
      + aluminum5 : SolidColor.SolidColor

      - aluminum6 : Color
      + aluminum6 : SolidColor.SolidColor

      - butter1 : Color
      + butter1 : SolidColor.SolidColor

      - butter2 : Color
      + butter2 : SolidColor.SolidColor

      - butter3 : Color
      + butter3 : SolidColor.SolidColor

      - chameleon1 : Color
      + chameleon1 : SolidColor.SolidColor

      - chameleon2 : Color
      + chameleon2 : SolidColor.SolidColor

      - chameleon3 : Color
      + chameleon3 : SolidColor.SolidColor

      - chocolate1 : Color
      + chocolate1 : SolidColor.SolidColor

      - chocolate2 : Color
      + chocolate2 : SolidColor.SolidColor

      - chocolate3 : Color
      + chocolate3 : SolidColor.SolidColor

      - orange1 : Color
      + orange1 : SolidColor.SolidColor

      - orange2 : Color
      + orange2 : SolidColor.SolidColor

      - orange3 : Color
      + orange3 : SolidColor.SolidColor

      - plum1 : Color
      + plum1 : SolidColor.SolidColor

      - plum2 : Color
      + plum2 : SolidColor.SolidColor

      - plum3 : Color
      + plum3 : SolidColor.SolidColor

      - scarletRed1 : Color
      + scarletRed1 : SolidColor.SolidColor

      - scarletRed2 : Color
      + scarletRed2 : SolidColor.SolidColor

      - scarletRed3 : Color
      + scarletRed3 : SolidColor.SolidColor

      - skyBlue1 : Color
      + skyBlue1 : SolidColor.SolidColor

      - skyBlue2 : Color
      + skyBlue2 : SolidColor.SolidColor

      - skyBlue3 : Color
      + skyBlue3 : SolidColor.SolidColor



---- Palette.X11 - MAJOR ----

    Changed:
      - aliceBlue : Color
      + aliceBlue : SolidColor.SolidColor

      - antiqueWhite : Color
      + antiqueWhite : SolidColor.SolidColor

      - aqua : Color
      + aqua : SolidColor.SolidColor

      - aquamarine : Color
      + aquamarine : SolidColor.SolidColor

      - azure : Color
      + azure : SolidColor.SolidColor

      - beige : Color
      + beige : SolidColor.SolidColor

      - bisque : Color
      + bisque : SolidColor.SolidColor

      - black : Color
      + black : SolidColor.SolidColor

      - blanchedAlmond : Color
      + blanchedAlmond : SolidColor.SolidColor

      - blue : Color
      + blue : SolidColor.SolidColor

      - blueViolet : Color
      + blueViolet : SolidColor.SolidColor

      - brown : Color
      + brown : SolidColor.SolidColor

      - burlywood : Color
      + burlywood : SolidColor.SolidColor

      - cadetBlue : Color
      + cadetBlue : SolidColor.SolidColor

      - chartreuse : Color
      + chartreuse : SolidColor.SolidColor

      - chocolate : Color
      + chocolate : SolidColor.SolidColor

      - coral : Color
      + coral : SolidColor.SolidColor

      - cornflowerBlue : Color
      + cornflowerBlue : SolidColor.SolidColor

      - cornsilk : Color
      + cornsilk : SolidColor.SolidColor

      - crimson : Color
      + crimson : SolidColor.SolidColor

      - cyan : Color
      + cyan : SolidColor.SolidColor

      - darkBlue : Color
      + darkBlue : SolidColor.SolidColor

      - darkCyan : Color
      + darkCyan : SolidColor.SolidColor

      - darkGoldenrod : Color
      + darkGoldenrod : SolidColor.SolidColor

      - darkGray : Color
      + darkGray : SolidColor.SolidColor

      - darkGreen : Color
      + darkGreen : SolidColor.SolidColor

      - darkKhaki : Color
      + darkKhaki : SolidColor.SolidColor

      - darkMagenta : Color
      + darkMagenta : SolidColor.SolidColor

      - darkOliveGreen : Color
      + darkOliveGreen : SolidColor.SolidColor

      - darkOrange : Color
      + darkOrange : SolidColor.SolidColor

      - darkOrchid : Color
      + darkOrchid : SolidColor.SolidColor

      - darkRed : Color
      + darkRed : SolidColor.SolidColor

      - darkSalmon : Color
      + darkSalmon : SolidColor.SolidColor

      - darkSeaGreen : Color
      + darkSeaGreen : SolidColor.SolidColor

      - darkSlateBlue : Color
      + darkSlateBlue : SolidColor.SolidColor

      - darkSlateGray : Color
      + darkSlateGray : SolidColor.SolidColor

      - darkTurquoise : Color
      + darkTurquoise : SolidColor.SolidColor

      - darkViolet : Color
      + darkViolet : SolidColor.SolidColor

      - deepPink : Color
      + deepPink : SolidColor.SolidColor

      - deepSkyBlue : Color
      + deepSkyBlue : SolidColor.SolidColor

      - dimGray : Color
      + dimGray : SolidColor.SolidColor

      - dodgerBlue : Color
      + dodgerBlue : SolidColor.SolidColor

      - firebrick : Color
      + firebrick : SolidColor.SolidColor

      - floralWhite : Color
      + floralWhite : SolidColor.SolidColor

      - forestGreen : Color
      + forestGreen : SolidColor.SolidColor

      - fuchsia : Color
      + fuchsia : SolidColor.SolidColor

      - gainsboro : Color
      + gainsboro : SolidColor.SolidColor

      - ghostWhite : Color
      + ghostWhite : SolidColor.SolidColor

      - gold : Color
      + gold : SolidColor.SolidColor

      - goldenrod : Color
      + goldenrod : SolidColor.SolidColor

      - gray : Color
      + gray : SolidColor.SolidColor

      - green : Color
      + green : SolidColor.SolidColor

      - greenYellow : Color
      + greenYellow : SolidColor.SolidColor

      - honeydew : Color
      + honeydew : SolidColor.SolidColor

      - hotPink : Color
      + hotPink : SolidColor.SolidColor

      - indianRed : Color
      + indianRed : SolidColor.SolidColor

      - indigo : Color
      + indigo : SolidColor.SolidColor

      - ivory : Color
      + ivory : SolidColor.SolidColor

      - khaki : Color
      + khaki : SolidColor.SolidColor

      - lavender : Color
      + lavender : SolidColor.SolidColor

      - lavenderBlush : Color
      + lavenderBlush : SolidColor.SolidColor

      - lawnGreen : Color
      + lawnGreen : SolidColor.SolidColor

      - lemonChiffon : Color
      + lemonChiffon : SolidColor.SolidColor

      - lightBlue : Color
      + lightBlue : SolidColor.SolidColor

      - lightCoral : Color
      + lightCoral : SolidColor.SolidColor

      - lightCyan : Color
      + lightCyan : SolidColor.SolidColor

      - lightGoldenrodYellow : Color
      + lightGoldenrodYellow : SolidColor.SolidColor

      - lightGray : Color
      + lightGray : SolidColor.SolidColor

      - lightGreen : Color
      + lightGreen : SolidColor.SolidColor

      - lightPink : Color
      + lightPink : SolidColor.SolidColor

      - lightSalmon : Color
      + lightSalmon : SolidColor.SolidColor

      - lightSeaGreen : Color
      + lightSeaGreen : SolidColor.SolidColor

      - lightSkyBlue : Color
      + lightSkyBlue : SolidColor.SolidColor

      - lightSlateGray : Color
      + lightSlateGray : SolidColor.SolidColor

      - lightSteelBlue : Color
      + lightSteelBlue : SolidColor.SolidColor

      - lightYellow : Color
      + lightYellow : SolidColor.SolidColor

      - lime : Color
      + lime : SolidColor.SolidColor

      - limeGreen : Color
      + limeGreen : SolidColor.SolidColor

      - linen : Color
      + linen : SolidColor.SolidColor

      - magenta : Color
      + magenta : SolidColor.SolidColor

      - maroon : Color
      + maroon : SolidColor.SolidColor

      - mediumAquamarine : Color
      + mediumAquamarine : SolidColor.SolidColor

      - mediumBlue : Color
      + mediumBlue : SolidColor.SolidColor

      - mediumOrchid : Color
      + mediumOrchid : SolidColor.SolidColor

      - mediumPurple : Color
      + mediumPurple : SolidColor.SolidColor

      - mediumSeaGreen : Color
      + mediumSeaGreen : SolidColor.SolidColor

      - mediumSlateBlue : Color
      + mediumSlateBlue : SolidColor.SolidColor

      - mediumSpringGreen : Color
      + mediumSpringGreen : SolidColor.SolidColor

      - mediumTurquoise : Color
      + mediumTurquoise : SolidColor.SolidColor

      - mediumVioletRed : Color
      + mediumVioletRed : SolidColor.SolidColor

      - midnightBlue : Color
      + midnightBlue : SolidColor.SolidColor

      - mintCream : Color
      + mintCream : SolidColor.SolidColor

      - mistyRose : Color
      + mistyRose : SolidColor.SolidColor

      - moccasin : Color
      + moccasin : SolidColor.SolidColor

      - navajoWhite : Color
      + navajoWhite : SolidColor.SolidColor

      - navy : Color
      + navy : SolidColor.SolidColor

      - oldLace : Color
      + oldLace : SolidColor.SolidColor

      - olive : Color
      + olive : SolidColor.SolidColor

      - oliveDrab : Color
      + oliveDrab : SolidColor.SolidColor

      - orange : Color
      + orange : SolidColor.SolidColor

      - orangeRed : Color
      + orangeRed : SolidColor.SolidColor

      - orchid : Color
      + orchid : SolidColor.SolidColor

      - paleGoldenrod : Color
      + paleGoldenrod : SolidColor.SolidColor

      - paleGreen : Color
      + paleGreen : SolidColor.SolidColor

      - paleTurquoise : Color
      + paleTurquoise : SolidColor.SolidColor

      - paleVioletRed : Color
      + paleVioletRed : SolidColor.SolidColor

      - papayaWhip : Color
      + papayaWhip : SolidColor.SolidColor

      - peachPuff : Color
      + peachPuff : SolidColor.SolidColor

      - peru : Color
      + peru : SolidColor.SolidColor

      - pink : Color
      + pink : SolidColor.SolidColor

      - plum : Color
      + plum : SolidColor.SolidColor

      - powderBlue : Color
      + powderBlue : SolidColor.SolidColor

      - purple : Color
      + purple : SolidColor.SolidColor

      - red : Color
      + red : SolidColor.SolidColor

      - rosyBrown : Color
      + rosyBrown : SolidColor.SolidColor

      - royalBlue : Color
      + royalBlue : SolidColor.SolidColor

      - saddleBrown : Color
      + saddleBrown : SolidColor.SolidColor

      - salmon : Color
      + salmon : SolidColor.SolidColor

      - sandyBrown : Color
      + sandyBrown : SolidColor.SolidColor

      - seaGreen : Color
      + seaGreen : SolidColor.SolidColor

      - seashell : Color
      + seashell : SolidColor.SolidColor

      - sienna : Color
      + sienna : SolidColor.SolidColor

      - silver : Color
      + silver : SolidColor.SolidColor

      - skyBlue : Color
      + skyBlue : SolidColor.SolidColor

      - slateBlue : Color
      + slateBlue : SolidColor.SolidColor

      - slateGray : Color
      + slateGray : SolidColor.SolidColor

      - snow : Color
      + snow : SolidColor.SolidColor

      - springGreen : Color
      + springGreen : SolidColor.SolidColor

      - steelBlue : Color
      + steelBlue : SolidColor.SolidColor

      - tan : Color
      + tan : SolidColor.SolidColor

      - teal : Color
      + teal : SolidColor.SolidColor

      - thistle : Color
      + thistle : SolidColor.SolidColor

      - tomato : Color
      + tomato : SolidColor.SolidColor

      - turquoise : Color
      + turquoise : SolidColor.SolidColor

      - violet : Color
      + violet : SolidColor.SolidColor

      - wheat : Color
      + wheat : SolidColor.SolidColor

      - white : Color
      + white : SolidColor.SolidColor

      - whiteSmoke : Color
      + whiteSmoke : SolidColor.SolidColor

      - yellow : Color
      + yellow : SolidColor.SolidColor

      - yellowGreen : Color
      + yellowGreen : SolidColor.SolidColor

apparently the transparent fuzzers aren't used. leaving them for now -- seems like tests are probably missing

BrianHicks · 2020-04-27T13:40:50Z

src/SolidColor.elm

-    ( Color
-    , fromRGB, fromHSL, fromHex
-    , toRGBString, toHSLString
+module SolidColor exposing


how would you feel about Color.Solid as a name, exposing Color? I think:

it's clear that it's a specialization of Color, in the way that Array.Hamt was a specialization of Array

it's a little nicer in the type signatures. import Color.Solid as Solid lets you do Solid.Color.

Hmm yeah! I could see that

BrianHicks · 2020-04-27T13:42:46Z

README.md

 orangyReds =
    [ orangeRed, tomato, coral, darkOrange, orange ]


-allTheButter : List Color
+allTheButter : List SolidColor


BrianHicks · 2020-04-27T13:43:24Z

README.md

@@ -31,13 +31,13 @@ myHex =
 Use helpers like `contrast` and `sufficientContrast` to verify that your font size, boldness, and colors meet accessibility standards.

 ```


would you be open to a PR to add checks for this with elm-verify-examples?

Yes!! (Although maybe after the major version release has actually occurred in order to not waste your time if this API doesn't make it 😅 )

ianmackenzie · 2020-04-30T22:18:45Z

I think I do like the "opaque" and "translucent" naming as suggested in #13 (comment) - so incorporating @BrianHicks' suggestion, maybe have Color.Opaque and Color.Translucent both exposing Color? My only reservation there is that the Elm package web site only shows non-prefixed type names, so it wouldn't be immediately obvious from the signature of a function as shown on the package web site whether it accepted an Opaque.Color or a Translucent.Color.

tesk9 added 9 commits April 24, 2020 18:38

Color -> SolidColor

594cff5

Color.Transparent -> TransparentColor

9686595

Color.Accessibility -> SolidColor.Accessibility

3ae7330

Move fuzzers into color fuzzer helper

cef195c

apparently the transparent fuzzers aren't used. leaving them for now -- seems like tests are probably missing

Move the transparent color spec to match module structure

79f820b

Move the accessibility spec to match module structure

737a604

Fix examples

76c2310

Updates readme

8560250

Rename example subsection

2d88a0b

tesk9 force-pushed the fix-namespace-collision-attempt-2 branch from 77dae34 to 2d88a0b Compare April 25, 2020 01:38

tesk9 mentioned this pull request Apr 25, 2020

Switch internal color type to avh/elm-color? #13

Closed

BrianHicks reviewed Apr 27, 2020

View reviewed changes

tesk9 merged commit 86d5d0d into master Jul 3, 2020

tesk9 deleted the fix-namespace-collision-attempt-2 branch July 3, 2020 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix namespace collision attempt 2 #26

Fix namespace collision attempt 2 #26

tesk9 commented Apr 25, 2020 •

edited

Loading

BrianHicks Apr 27, 2020

tesk9 Apr 29, 2020

BrianHicks Apr 27, 2020

BrianHicks Apr 27, 2020

tesk9 Apr 29, 2020

ianmackenzie commented Apr 30, 2020

		@@ -31,13 +31,13 @@ myHex =
		Use helpers like `contrast` and `sufficientContrast` to verify that your font size, boldness, and colors meet accessibility standards.

		```

Fix namespace collision attempt 2 #26

Fix namespace collision attempt 2 #26

Conversation

tesk9 commented Apr 25, 2020 • edited Loading

BrianHicks Apr 27, 2020

Choose a reason for hiding this comment

tesk9 Apr 29, 2020

Choose a reason for hiding this comment

BrianHicks Apr 27, 2020

Choose a reason for hiding this comment

BrianHicks Apr 27, 2020

Choose a reason for hiding this comment

tesk9 Apr 29, 2020

Choose a reason for hiding this comment

ianmackenzie commented Apr 30, 2020

tesk9 commented Apr 25, 2020 •

edited

Loading