Added tests for the get/set pollTime #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved by @jiahuang. Running tests. |
tm-rampart
added a commit
that referenced
this pull request
Feb 13, 2015
|
Thanks for the fixed tests! Forgot that you didn't need to check if the GPS is ready since the poll time settings don't need to communicate with the GPS module. |
|
No dramas. All I needed in the end was the 1..9 at the start. I have been too use to phpunit lately and its been about 7 years since I last looked at TAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out my issues. It has been a long time since I have seen the TAP protocol and completely forgot how it was supposed to work.