t2 run: fix uglify-es compression bug by adding arrow: false. Remove …

…affected modules from blacklist.
tessel · Aug 4, 2017 · d3de424 · d3de424 · kzc · Aug 7, 2017
1 parent 7c6e802
commit d3de424
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/lib/tessel/deployment/javascript.js b/lib/tessel/deployment/javascript.js
@@ -802,11 +802,12 @@ exportables.compress = function(source, options) {
     properties: true,
     sequences: true,
     unsafe: true,
-    // ------
+    // ------ potentially dangerous
     dead_code: true,
     unsafe_math: true,
     keep_infinity: true,
-    // ------
+    // ------ explicitly false
+    arrows: false,
     keep_fargs: false,
     keep_fnames: false,
     warnings: false,

diff --git a/lib/tessel/deployment/lists/javascript.js b/lib/tessel/deployment/lists/javascript.js
@@ -5,6 +5,7 @@ module.exports = {
     'node_modules/**/negotiator/**/*.js',
     'node_modules/**/socket.io-client/socket.io.js',
     'node_modules/**/socket.io-client/dist/socket.io.min.js',
+    'node_modules/**/socket.io-client/dist/socket.io.js',
   ],
 
   ignores: [
@@ -44,7 +45,8 @@ module.exports = {
      */
   },
   compressionOptions: {
-    'extend': {
+    // "extend" is the name of the module
+    extend: {
       compress: {
         keep_fnames: true
       },
@@ -53,10 +55,5 @@ module.exports = {
   },
   compressionBlacklist: {
     bindings: true,
-    base64id: true,
-    'component-inherit': true,
-    express: true,
-    'fraction.js': true,
-    'mongodb': true,
   },
 };
diff --git a/test/unit/deployment/javascript.js b/test/unit/deployment/javascript.js
@@ -291,7 +291,7 @@ exports['deployment.js.compress'] = {
   },
 
   noOptionsCompress(test) {
-    test.expect(22);
+    test.expect(23);
 
     const optionsCompress = {
       // ------
@@ -315,6 +315,7 @@ exports['deployment.js.compress'] = {
       unsafe_math: true,
       keep_infinity: true,
       // ------
+      arrows: false,
       keep_fargs: false,
       keep_fnames: false,
       warnings: false,
@@ -335,7 +336,7 @@ exports['deployment.js.compress'] = {
   },
 
   ourOptionsCompress(test) {
-    test.expect(22);
+    test.expect(23);
 
     const ourExplicitSettings = {
       // ------
@@ -359,6 +360,7 @@ exports['deployment.js.compress'] = {
       unsafe_math: true,
       keep_infinity: true,
       // ------
+      arrows: false,
       keep_fargs: false,
       keep_fnames: false,
       warnings: false,
@@ -3381,6 +3383,7 @@ exports['deployment.js.lists'] = {
       'node_modules/**/negotiator/**/*.js',
       'node_modules/**/socket.io-client/socket.io.js',
       'node_modules/**/socket.io-client/dist/socket.io.min.js',
+      'node_modules/**/socket.io-client/dist/socket.io.js',
     ];
 
     test.deepEqual(lists.includes, includes);