Followup #792: #819
Merged
Followup #792: #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also amends previous tests to use the correct password property (pass) for the createAccessPoint options object.
HipsterBrown
force-pushed
the
validation-fix
branch
from
57962ff
to
09a34f6
Compare
|
Pinging @rwaldron for review when available. |
| @@ -495,7 +495,7 @@ makeCommand('ap') | |||
| abbr: 'n', | |||
| help: 'Name of the network.' | |||
| }) | |||
| .option('pass', { | |||
| .option('password', { | |||
There was a problem hiding this comment.
I feel bad it was in there in the first place. Not sure what I was thinking.
HipsterBrown
force-pushed
the
validation-fix
branch
from
7d115f8
to
7e6f135
Compare
|
LGTM Land at will. We will release tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createAccessPointpassword and security validation.