Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tune release script #839

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

mdelapenya
Copy link
Member

  • fix: unstash does not exist
  • fix: use the right IRL endpoint for go proxy

What does this PR do?

It fixes two parts of the release script:

  • replaces git unstash 🤦 with git stash pop
  • appends the .info suffix to the Go proxy URL

Why is it important?

Otherwise it's not possible to perform the release

Related issues

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Feb 16, 2023
@mdelapenya mdelapenya self-assigned this Feb 16, 2023
@mdelapenya mdelapenya requested a review from a team as a code owner February 16, 2023 12:54
@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 91fd924
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/63ee276bd514b9000872350a
😎 Deploy Preview https://deploy-preview-839--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya merged commit 0572ed8 into testcontainers:main Feb 16, 2023
@mdelapenya mdelapenya deleted the fix-release-script branch February 21, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant