Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate examples to junit5 #7417

Merged
merged 19 commits into from
Aug 30, 2023
Merged

Migrate examples to junit5 #7417

merged 19 commits into from
Aug 30, 2023

Conversation

samed-bicer
Copy link
Contributor

@samed-bicer samed-bicer commented Aug 16, 2023 •
edited
Loading

migrate examples from junit4 to junit5
#6921

@samed-bicer samed-bicer marked this pull request as ready for review August 16, 2023 01:04
@samed-bicer samed-bicer requested a review from a team as a code owner August 16, 2023 01:04
@samed-bicer
Copy link
Contributor Author

hi @eddumelendez, examples are migrated to junit5. Could you please review the PR, thanks!

eddumelendez
eddumelendez reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using JUnit 5, public can be removed from test classes and methods. Please apply this change.

Thanks!

@samed-bicer
Copy link
Contributor Author

samed-bicer commented Aug 25, 2023 •
edited
Loading

Using JUnit 5, public can be removed from test classes and methods. Please apply this change.

Thanks!

Hi @eddumelendez
It has been removed from classes and methods, thanks.
The ci job for tubo-mode is failing with timeout, is there any solution for that?

@eddumelendez eddumelendez merged commit 1084b20 into testcontainers:main Aug 30, 2023
85 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution @samed-bicer !

@eddumelendez eddumelendez added this to the next milestone Aug 30, 2023
@eddumelendez eddumelendez mentioned this pull request Sep 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@samed-bicer @eddumelendez