Normalize image names in prefix substitutor

[findepi]

Optionally normalize docker image names to use library/ prefix when they don't have any namespace at all. This allows for the PrefixingImageNameSubstitutor to be used to redirect Docker Hub requests to a private registry without having to apply otherwise redundant changes to the test code.

[eddumelendez]

@findepi thanks for your contribution, can you please add some docs?

[findepi]

@eddumelendez thanks for review!
sure, where this should be documented?

[eddumelendez]

I think https://java.testcontainers.org/features/image_name_substitution/ is ok

[findepi]

Added this. cc @eddumelendez.

Did i get the env variable name right?
There is automatic conversion from TESTCONTAINERS_HUB_IMAGE_NAME_NORMALIZE to hub.image.name.normalize, right?

[eddumelendez]

yes, the name is correct.

When this option is used, Testcontainers will additionally disable image compatibility checks done by some containers, so it the compatibility responsibility is on the user.

I don't think this is the case because the check compatibility is executed first. Can you please add a test similar to

testcontainers-java/core/src/test/java/org/testcontainers/utility/ImageNameSubstitutorTest.java

Lines 58 to 68 in 00cc0ea

	@Test
	public void testWorksWithoutConfiguredImplementation() {
	Mockito.doReturn(null).when(TestcontainersConfiguration.getInstance()).getImageSubstitutorClassName();
	final ImageNameSubstitutor imageNameSubstitutor = ImageNameSubstitutor.instance();
	DockerImageName result = imageNameSubstitutor.apply(DockerImageName.parse("original"));
	assertThat(result.asCanonicalNameString())
	.as("the image has been substituted by default then configured implementations")
	.isEqualTo("substituted-image:latest");
	}

in order to cover it?

[findepi]

I don't think this is the case because the check compatibility is executed first.

that makes sense!

however, when testing this PR internally, i run into some issues until i added "as compatible substitute" call.
is it possible that there are some additional checks somewhere else? sadly, don't have stacktrace now

[findepi]

The build failed (core)

Gradle Test Executor 10 > org.testcontainers.junit.DockerComposeContainerScalingTest > simpleTest FAILED
    org.junit.ComparisonFailure: [Each redis instance is separate] expected:<"[1]"> but was:<"[2]">
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at org.testcontainers.junit.DockerComposeContainerScalingTest.simpleTest(DockerComposeContainerScalingTest.java:54)

I will need some guidance, I don't know how to fix it.

[eddumelendez]

@findepi can you run ./gradlew spotlessApply --no-daemon, please?

[findepi]

@eddumelendez done!

[findepi]

CI green this time. Sorry for missing spotless on the previous push.

[findepi]

I see test failure https://app.circleci.com/pipelines/github/testcontainers/testcontainers-java/11624/workflows/67da8da7-fbdc-42d2-94ab-c6e59c101324/jobs/43677

     Caused by:
            com.github.dockerjava.api.exception.DockerClientException: Could not pull image: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/redis:3.0.2 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

in https://github.com/trinodb/trino we solved similar failures by bumping the image version, but I am not sure this is the way to go here.

@eddumelendez please let me know what do you think about this