Clean up window/global management #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures the lodash build for browser tests is same one for node tests. Versioning and updating of vendor is now simply through package.json and handles both browser and node
same as with lodash: serving from node_modules ensures same version of mocha-given between node/browser. no need to manage in-repo vendor file
browser helper sets mocha ui to mocha-given
Now that subject is being served from the standard build file (dist/), and mocha-given is being served from node_modules, we don't need custom script tags in the test page. And the browser-helper sets mocha-given as the mocha UI so we don't need that in the test page either. That gets us back to the OOTB mocha+chai test page that ships with testem.
jasonkarns
force-pushed
the
window-global
branch
from
a7e1eaf
to
8a0176f
Compare
|
all concerns resolved, i believe. branch has been rebased onto master |
|
blindly merged because i trust jason |
searls
added a commit
that referenced
this pull request
Sep 14, 2015
Clean up window/global management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.