[CI mode, ember-cli test] enabling WebSocket proxying #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple patch leveraging WebSocket proxying capabilities of http-proxy by an entry identifying itself as "ws: true" in the testem.json/testem.js 'proxies' section (cf. https://github.com/testem/testem?tab=readme-ov-file#api-proxy): … "proxies": { … "/mywsendpoint": { … ws: true }, … } Works with ember-cli test, offering equivalent functionality to ember-cli server --proxy=… in CI testing mode.
IBue
force-pushed
the
patch-websocket-proxying
branch
from
6c07e6c
to
5b14762
Compare
| }); | ||
|
|
||
| Object.keys(proxies).forEach(url => { | ||
| Object.keys(proxies).forEach((url) => { | ||
| if (proxies[url].ws === true) { |
There was a problem hiding this comment.
Would it be possible to add a test for this? Here are the existing ones https://github.com/testem/testem/blob/master/tests/server_tests.js
|
I worked out the tests for ws → ws/wss proxying. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple patch leveraging WebSocket proxying capabilities of http-proxy by an entry identifying itself as
"ws: true"in thetestem.json/testem.js'proxies' section(cf. https://github.com/testem/testem?tab=readme-ov-file#api-proxy):
Works with
ember-cli test, offering equivalent functionality toember-cli server --proxy=…in CI testing mode.