fix: remove extra command log message for get* queries #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #103
What:
Removing extra log message for
get*queries.Before:
After:
Why:
It isn't really a big deal, but it is a bit distracting seeing the log message multiple times - once as a spinner (Cypress thinks the log is still pending because the error prevented it from closing) and once as an error line.
How:
I removed the
Cypress.log. Logs usually need an.end()to tell Cypress when the log is closed since Cypress commands are asynchronous. Cypress is already logging errors in commands for us, so we don't need to log as well.Checklist: