Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support anonymous custom elements when pretty printing DOM #1319

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

KonnorRogers
Copy link
Contributor

Fixes #1191

@KonnorRogers KonnorRogers changed the title Support anonymous custom elements Support anonymous custom elements in pretty-dom Jun 19, 2024
Copy link

codesandbox-ci bot commented Jun 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8206426:

Sandbox Source
react-testing-library-examples Configuration

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please add a test illustrating the intended behavior

@KonnorRogers
Copy link
Contributor Author

@eps1lon I could see how that could be helpful 😆 let me work on it.

@KonnorRogers
Copy link
Contributor Author

@eps1lon Done!

I also noticed there was no test for named custom elements so I added one.

Let me know if there's anything else I can do :)

@eps1lon eps1lon changed the title Support anonymous custom elements in pretty-dom feat: Support anonymous custom elements in pretty-dom Jun 24, 2024
@eps1lon eps1lon changed the title feat: Support anonymous custom elements in pretty-dom feat: Support anonymous custom elements when pretty printing DOM Jun 24, 2024
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eps1lon eps1lon merged commit 0a8ad65 into testing-library:main Jun 24, 2024
6 checks passed
@KonnorRogers KonnorRogers deleted the patch-1 branch June 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializing anonymous classes of custom elements doesnt work with prettyDOM.
2 participants