Fix getByRole('link') not returning anchor elements #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @afontcu for code and tests |
|
I've put up a pull request to add @afontcu! 🎉 |
|
🎉 This PR is included in version 5.5.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR tries to close #313 😇
Why:
getByRole('link')wasn't returning valid anchor elements (read: anchors withhrefattribute).How:
I simply check if
valueis set, and change the return format accordingly. I kept it simple and readable, feel free to suggest some JavaScript calisthenics to improve the resulting function!Checklist:
I discovered that only
<a>and<area>suffer from "value-less" attributes. Following is an output of elements provided byaria-queryand their associated attribute array:Thanks! 👋