feat(byRole): Improve performance #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Oct 13, 2019
|
Whoops! Didn't realize that this code isn't full covered by tests 😬 |
|
Hm I wanted to see how this Codesandbox CI works. Guess I have to add a config anyway 😄 |
|
🎉 This PR is included in version 6.8.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Addresses #379
Why:
Queries can be used when polling the DOM. If the query is slower than the polling rate we'll run into timeouts
How:
Since |elements| >> |elements with role| and getting the role is far less expensive than deciding if an element is part of the a11y tree it's far cheaper to query the elements for the role before checking if an element is part of the a11y tree.
Checklist:
[ ] Documentation added to thedocs site
I've prepared a PR for types targetting https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom