Skip to content

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 1, 2020

Fixes #421
What:

Use createEvent instead of new Event if Event is not constructable

Why:

new Event is not supported in IE 11

How:

Use https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent#Polyfill

Checklist:

@eps1lon eps1lon added the bug Something isn't working label Feb 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f6550d:

Sandbox Source
focused-goldberg-upfge Configuration

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #445 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #445   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          22     22           
  Lines         384    385    +1     
  Branches       90     91    +1     
=====================================
+ Hits          384    385    +1
Impacted Files Coverage Δ
src/events.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce9921...6f6550d. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review February 1, 2020 22:07
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kentcdodds kentcdodds merged commit 1ee3e7a into testing-library:master Feb 2, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eps1lon eps1lon deleted the fix/ie11-events branch February 2, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fireEvent is not working on IE
2 participants