fix: runWithRealTimers to be compatible with new version of jest #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 092a72f:
|
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 574 574
Branches 145 145
=========================================
Hits 574 574
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Jun 15, 2020
| globalObj.setTimeout && | ||
| globalObj.setTimeout._isMockFunction && | ||
| (globalObj.setTimeout._isMockFunction || | ||
| typeof globalObj.setTimeout.clock !== 'undefined') && |
There was a problem hiding this comment.
I have tried to find a different way but I didn't find
|
🎉 This PR is included in version 7.15.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This change will fix issue #612.
Why:
With the version 26.0.0 of jest the
jest.useFakeTimersfunction uses@sinonjs/fake-timers.With this new package the property
_isMockFunctionis no more available.How:
To fix the issue I have added a new check to
clockproperty.@testing-library/domis now compatible with both version ofuseFakeTimers, the legacy and the modern one.Checklist:
docs site