fix(no-unnecessary-act): report everything that's reported in non-str…

…ict (#423) * fix(no-unnecessary-act): report everything that's reported in non-strict * refactor: remove duplication in tests Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Closes #416
testing-library · Jul 21, 2021 · 840763d · 840763d
1 parent a8cc355
commit 840763d
Show file tree

Hide file tree

Showing 2 changed files with 514 additions and 495 deletions.
diff --git a/lib/rules/no-unnecessary-act.ts b/lib/rules/no-unnecessary-act.ts
@@ -14,7 +14,7 @@ export const RULE_NAME = 'no-unnecessary-act';
 export type MessageIds =
   | 'noUnnecessaryActEmptyFunction'
   | 'noUnnecessaryActTestingLibraryUtil';
-type Options = [{ isStrict: boolean }];
+export type Options = [{ isStrict: boolean }];
 
 export default createTestingLibraryRule<Options, MessageIds>({
   name: RULE_NAME,
@@ -144,8 +144,9 @@ export default createTestingLibraryRule<Options, MessageIds>({
       }
 
       const shouldBeReported = isStrict
-        ? hasSomeNonTestingLibraryCall(blockStatementNode.body) &&
-          hasTestingLibraryCall(blockStatementNode.body)
+        ? (hasSomeNonTestingLibraryCall(blockStatementNode.body) &&
+            hasTestingLibraryCall(blockStatementNode.body)) ||
+          !hasSomeNonTestingLibraryCall(blockStatementNode.body)
         : !hasSomeNonTestingLibraryCall(blockStatementNode.body);
 
       if (shouldBeReported) {