Skip to content

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Oct 3, 2025

Checks

Changes

  • Updated rule logic to better distinguish between unique async elements.
  • Update doc and test.

Context

Fixes #1084


This is completely unrelated to the changes in this PR, but I noticed an error in the "Upload coverage reports to Codecov" step, and the coverage notification is not being sent.
Is this something we should be concerned about, or is it fine to ignore?

@Belco90 Belco90 self-requested a review October 6, 2025 11:42
@y-hsgw y-hsgw requested a review from Belco90 October 6, 2025 12:32
@y-hsgw y-hsgw requested a review from Belco90 October 6, 2025 13:40
@Belco90
Copy link
Member

Belco90 commented Oct 6, 2025

This is completely unrelated to the changes in this PR, but I noticed an error in the "Upload coverage reports to Codecov" step, and the coverage notification is not being sent.
Is this something we should be concerned about, or is it fine to ignore?

I need to check this independently. Would you mind creating a separate issue for it? @y-hsgw

@Belco90 Belco90 changed the title feat(no-wait-for-multiple-assertions):only forbid multiple assertions on the same async target feat(no-wait-for-multiple-assertions): avoid reporting unrelated assertions Oct 6, 2025
@Belco90 Belco90 enabled auto-merge (squash) October 6, 2025 13:49
@Belco90 Belco90 merged commit db8756c into main Oct 6, 2025
32 checks passed
@Belco90 Belco90 deleted the feature/update-no-wait-for-multiple-assertions branch October 6, 2025 13:50
Copy link

github-actions bot commented Oct 6, 2025

🎉 This PR is included in version 7.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine no-wait-for-multiple-assertions: Only forbid multiple assertions on the same async target
2 participants